/[winpt]/trunk/Src/wptKeyserver.cpp

Diff of /trunk/Src/wptKeyserver.cpp

Parent Directory | Revision Log | View Patch Patch

-revision 73 by twoaday,
Tue Nov  8 07:15:13 2005 UTC
+revision 180 by twoaday,
Mon Mar  6 14:41:58 2006 UTC
 Line 24
  #endif
  #include <windows.h>
+ #include <shlobj.h>
  #include <stdio.h>
  #include <sys/stat.h>
  #include <ctype.h>
-Line 33
+Line 34
  #include "wptTypes.h"
  #include "wptNLS.h"
  #include "wptW32API.h"
- #include "wptVersion.h"
  #include "wptGPG.h"
  #include "wptRegistry.h"
+ #define net_errno ((int)WSAGetLastError ())
  static char base64code[] =
    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
  keyserver server[MAX_KEYSERVERS] = {0};
- static keyserver_proxy_ctx proxy = {0};
+ keyserver_proxy_s proxy = {0};
- static const char * server_list[] = {
+ static const char *server_list[] = {
      "hkp://wwwkeys.nl.pgp.net",
      "hkp://wwwkeys.pl.pgp.net",
      "hkp://wwwkeys.at.pgp.net",
-Line 54 
 static const char * server_list[] = {
+Line 56 
 static const char * server_list[] = {
      "hkp://wwwkeys.eu.pgp.net",
      "hkp://wwwkeys.uk.pgp.net",
      "hkp://wwwkeys.us.pgp.net",
-     "hkp://gnv.us.ks.cryptnet.net",
      "hkp://subkeys.pgp.net",
      "ldap://keyserver.pgp.com",
      NULL
  };
- static char hkp_errmsg[1024];
- static int hkp_err = 0;
- static u32 conf_timestamp = 0;
- char * default_keyserver = NULL;
- unsigned short default_keyserver_port = 0;
+ static char  hkp_errmsg[1024];  /* Holds the error message from the server */
+ static int   hkp_err = 0;       /* != 0 indicates an error occurred. */
+ static DWORD conf_timestamp = 0;/* timestamp of the configuration fiele. */
+ /* Default keyserver and port. */
+ char *default_keyserver = NULL;
+ WORD default_keyserver_port = 0;
+ /* Basic64 encode the input @inbuf to @outbuf. */
  static void
- base64_encode( const char *inputstr, char *outputstr, int maxlen )
+ base64_encode (const char *inbuf, char *outbuf)
  {
-     int index = 0, temp = 0, res = 0, i = 0, inputlen = 0, len = 0;
+     int index = 0, temp = 0, res = 0;
+     int i = 0, inputlen = 0, len = 0;
-     inputlen = strlen (inputstr); /* fixme: check if len > maxlen */
+     inputlen = strlen (inbuf);
-     for (i = 0; i <inputlen; i++) {
+     for (i = 0; i < inputlen; i++) {
          res = temp;
-         res = (res << 8) | (inputstr[i] & 0xFF);
+         res = (res << 8) | (inbuf[i] & 0xFF);
          switch (index++) {
-         case 0: outputstr[len++] = base64code[res >> 2 & 0x3F]; res &= 0x3; break;
+         case 0:
-         case 1: outputstr[len++] = base64code[res >> 4 & 0x3F]; res &= 0xF; break;
+             outbuf[len++] = base64code[res >> 2 & 0x3F];
-         case 2: outputstr[len++] = base64code[res >> 6 & 0x3F];
+             res &= 0x3;
-                 outputstr[len++] = base64code[res & 0x3F]; res = index = 0; break;
+             break;
+         case 1:
+             outbuf[len++] = base64code[res >> 4 & 0x3F];
+             res &= 0xF;
+             break;
+         case 2:
+             outbuf[len++] = base64code[res >> 6 & 0x3F];
+             outbuf[len++] = base64code[res & 0x3F];
+             res = index = 0;
+             break;
          }
          temp = res;
      }
-     switch( index ) {
+     if (index == 2) {
-     case 0: break;
+         outbuf[len++] = base64code[temp << 2 & 0x3F];
-     case 2: outputstr[len++] = base64code[temp << 2 & 0x3F];
+         outbuf[len++] = '=';
-             outputstr[len++] = '='; break;
-     case 1: outputstr[len++] = base64code[temp << 4 & 0x3F];
-             outputstr[len++] = '=';
-             outputstr[len++] = '=';
      }
+     else if (index == 1) {
-     outputstr[len] = '\0';
+         outbuf[len++] = base64code[temp << 4 & 0x3F];
- } /* base64_encode */
+         outbuf[len++] = '=';
+         outbuf[len++] = '=';
+     }
+     outbuf[len] = '\0';
+ }
  /* Skip the URL schema and return only the host part of it. */
- static const char *
+ static const char*
- skip_type_prefix (const char * hostname)
+ skip_type_prefix (const char *hostname)
  {
      if (hostname && !strncmp (hostname, "http://", 7))
          hostname += 7;
-Line 117 
 skip_type_prefix (const char * hostname)
+Line 134 
 skip_type_prefix (const char * hostname)
     Return 0 on success. */
  static int
  check_hkp_response (const char *resp, int recv)
  {
+     char *p, *end;
      int ec, len;
-     char *p, * end;
      ec = recv ? WPTERR_WINSOCK_RECVKEY : WPTERR_WINSOCK_SENDKEY;
      if (!strstr (resp, "HTTP/1.0 200 OK") &&
-Line 132 
 check_hkp_response (const char *resp, in
+Line 149 
 check_hkp_response (const char *resp, in
          if (p && strlen (p) < sizeof (hkp_errmsg)) {
              end = strstr (p, "</p>");
              len = end? (end - p + 1) : strlen (p);
+             memset (hkp_errmsg, 0, sizeof (hkp_errmsg));
              strncpy (hkp_errmsg, p, len);
              hkp_err = 1;
          }
-Line 147 
 static int
+Line 165 
 static int
  sock_getline (int fd, char *buf, int buflen, int *nbytes)
  {
      char ch;
-     int count = 0;
+     int nread = 0;
      if (nbytes)
          *nbytes = 0;
      *buf = 0;
      while (recv (fd, &ch, 1, 0) > 0) {
          *buf++ = ch;
-         count++;
+         nread++;
-         if (ch == '\n' || count == (buflen - 1)) {
+         if (ch == '\r')
+             continue; /* remove this char. */
+         if (ch == '\n' || nread == (buflen - 1)) {
              *buf = 0;
              if (nbytes)
-                 *nbytes = count;
+                 *nbytes = nread;
              return 0;
          }
      }
-Line 177 
 sock_select (int fd, int nsecs)
+Line 197 
 sock_select (int fd, int nsecs)
      FD_ZERO (&rfd);
      FD_SET (fd, &rfd);
-     if (select (fd + 1, &rfd, NULL, NULL, &tv) == SOCKET_ERROR)
+     if (select (fd + 1, &rfd, NULL, NULL, &tv) == SOCKET_ERROR) {
+         log_debug ("sock_select: select() failed ec=%d.\r\n", net_errno);
          return SOCKET_ERROR;
+     }
      if (FD_ISSET (fd, &rfd))
          return 1;
      return 0;
  }
- /* Read from a socket with a fixed timeout of 10 seconds.
+ /* Read from a socket @fd to buffer @buf with a fixed timeout
+    of 10 seconds. The amount of bytes which were read are
+    returned in @nbytes.
     Return value: 0 on success. */
  static int
  sock_read (int fd, char *buf, int buflen, int *nbytes)
-Line 199 
 sock_read (int fd, char *buf, int buflen
+Line 223 
 sock_read (int fd, char *buf, int buflen
              return WPTERR_WINSOCK_TIMEOUT;
          rc = sock_select (fd, 1);
          if (rc == SOCKET_ERROR)
-             return SOCKET_ERROR;
+             return rc;
-         else if( !rc )
+         else if (!rc)
              n++;
          else {
              nread = recv (fd, buf, nleft, 0);
-             if (nread == SOCKET_ERROR)
+             if (nread == SOCKET_ERROR) {
+                 log_debug ("sock_read: recv() failed ec=%d.\r\n", net_errno);
                  return SOCKET_ERROR;
+             }
              else if (!nread)
                  break;
              nleft -= nread;
-Line 218 
 sock_read (int fd, char *buf, int buflen
+Line 244 
 sock_read (int fd, char *buf, int buflen
      return 0;
  }
+ /* Read much data as possible from the socket @fd and
+    return the data in @buffer. Caller must free data.
+    Return value: 0 on success. */
+ int
+ sock_read_ext (int fd, char **buffer, int *r_bufferlen)
+ {
+     gpgme_data_t dh;
+     char buf[1024], *p;
+     size_t n=0;
+     int nread, rc;
+     gpgme_data_new (&dh);
+     while (n < 10) {
+         rc = sock_select (fd, 1);
+         if (rc == SOCKET_ERROR) {
+             gpgme_data_release (dh);
+             return rc;
+         }
+         else if (!rc)
+             n++;
+         else {
+             nread = recv (fd, buf, sizeof (buf), 0);
+             if (nread == SOCKET_ERROR)
+                 return SOCKET_ERROR;
+             else if (!nread)
+                 break;
+             gpgme_data_write (dh, buf, nread);
+         }
+     }
+     gpg_data_putc (dh, '\0');
+     p = gpgme_data_release_and_get_mem (dh, &n);
+     *buffer = m_strdup (p);
+     if (r_bufferlen)
+         *r_bufferlen = n;
+     gpgme_free (p);
+     return 0;
+ }
- /* Write @buf to a socket @fd. */
+ /* Write the buffer @buf with the length @buflen to a socket @fd. */
  static int
  sock_write (int fd, const char *buf, int buflen)
  {
-Line 228 
 sock_write (int fd, const char *buf, int
+Line 292 
 sock_write (int fd, const char *buf, int
      while (nleft > 0) {
          nwritten = send (fd, buf, nleft, 0);
-         if (nwritten == SOCKET_ERROR)
+         if (nwritten == SOCKET_ERROR) {
+             log_debug ("sock_write: send() failed ec=%d\r\n", net_errno);
              return SOCKET_ERROR;
+         }
          nleft -= nwritten;
          buf += nwritten;
      }
      return 0;
  }
+ /* Set the default keyserver. */
  void
  set_default_kserver (void)
  {
-     char * p = get_reg_entry_keyserver ("Default");
+     char *p = get_reg_entry_keyserver ("Default");
      free_if_alloc (default_keyserver);
      default_keyserver = p && *p != ' ' ? p : m_strdup (DEF_HKP_KEYSERVER);
      p = get_reg_entry_keyserver ("Default_Port");
      if (p && *p) {
-         default_keyserver_port = (u16)strtoul (p, NULL, 10);
+         default_keyserver_port = (WORD)strtoul (p, NULL, 10);
          free_if_alloc (p);
      }
      else
-Line 260 
 wsock_init (void)
+Line 327 
 wsock_init (void)
  {
      WSADATA wsa;
-     if (WSAStartup (0x202, &wsa))
+     if (WSAStartup (0x202, &wsa)) {
+         log_debug ("wsock_init: WSAStartup failed ec=%d\r\n", net_errno);
          return WPTERR_WINSOCK_INIT;
+     }
      set_default_kserver ();
      return 0;
  }
-Line 271 
 wsock_init (void)
+Line 340 
 wsock_init (void)
  void
  wsock_end (void)
  {
+     char *p;
      int i;
+     p = make_special_filename (CSIDL_APPDATA, "winpt\\keyserver.conf", NULL);
+     kserver_save_conf (p);
+     free_if_alloc (p);
      free_if_alloc (default_keyserver);
-     default_keyserver = NULL;
      for (i=0; i < MAX_KEYSERVERS; i++) {
          if (server[i].used)
              free_if_alloc (server[i].name);
      }
+     kserver_proxy_release (&proxy);
      WSACleanup ();
  }
-Line 291 
 wsock_strerror (void)
+Line 364 
 wsock_strerror (void)
      int ec = WSAGetLastError ();
      switch (ec) {
      case WSAENETDOWN:
          return _("The network subsystem has failed");
      case WSAHOST_NOT_FOUND:
          return _("Authoritative Answer Host not found");
      case WSAETIMEDOUT:
          return _("The connection has been dropped because of a network failure");
      default:
          _snprintf (buf, sizeof (buf) -1, _("Unknown Winsock error ec=%d"),ec);
          return buf;
      }
-Line 318 
 kserver_strerror (void)
+Line 391 
 kserver_strerror (void)
  /* Read a keyserver from the list at index @idx.
     Return value: keyserver name at the given position. */
  const char*
- kserver_get_hostname (int idx, int type, u16 *port)
+ kserver_get_hostname (int idx, int type, WORD *port)
  {
      if (type == -1) {
          *port = default_keyserver_port;
-Line 347 
 kserver_check_inet_connection (void)
+Line 420 
 kserver_check_inet_connection (void)
  }
- /*
+ /* If the request contains the keyid, it have to be
-  * If the request contains the keyid, it have to be
+    always postfix with '0x'+keyid. This code checks
-  * always postfix with '0x'+keyid. This code checks
+    if the keyid is a decimal value and if so if it contains
-  * if the keyid is a decimal value and if so if it contains
+    the '0x'. If not it is inserted. */
-  * the '0x'. If not it is inserted.
-  */
  const char*
  kserver_check_keyid (const char *keyid)
  {
-     static char id[20];
+     static char id[21];
      if (strstr (keyid, "@"))
          return keyid; /* email address */
-Line 366 
 kserver_check_keyid (const char *keyid)
+Line 437 
 kserver_check_keyid (const char *keyid)
          return id;
      }
      return keyid;
- } /* kserver_check_keyid */
+ }
+ /* Update the keyserver proxy user. */
  static void
- kserver_update_proxyuser (const char *proxy_user, const char *proxy_pass)
+ update_proxy_user (const char *proxy_user, const char *proxy_pass)
  {
      char t[257]; /* user:pass = 127+1+127+1 = 257 */
      int n = 0;
-Line 381 
 kserver_update_proxyuser (const char *pr
+Line 453 
 kserver_update_proxyuser (const char *pr
      if (!proxy.base64_user)
          BUG (0);
      _snprintf (t, sizeof (t)-1, "%s:%s", proxy_user, proxy_pass);
-     base64_encode (t, proxy.base64_user, 257);
+     base64_encode (t, proxy.base64_user);
      free_if_alloc (proxy.user);
      free_if_alloc (proxy.pass);
      proxy.user = m_strdup (proxy_user);
      proxy.pass = m_strdup (proxy_pass);
- } /* kserver_update_proxyuser */
+ }
  /* Check that the given buffer contains a valid keyserver URL. */
-Line 419 
 port_from_proto (int proto)
+Line 491 
 port_from_proto (int proto)
  /* Get the port number from the given URL. */
  static int
- proto_from_URL (const char * buf)
+ proto_from_URL (const char *buf)
  {
      if (strstr( buf, "ldap"))
          return KSPROTO_LDAP;
-Line 430 
 proto_from_URL (const char * buf)
+Line 502 
 proto_from_URL (const char * buf)
  void
- keyserver_set_default (const char * hostname, u16 port)
+ keyserver_set_default (const char *hostname, WORD port)
  {
      if (hostname) {
          free_if_alloc (default_keyserver);
-Line 443 
 keyserver_set_default (const char * host
+Line 515 
 keyserver_set_default (const char * host
      server[0].used = 1;
      server[0].port = port;
      server[0].proto = proto_from_URL (default_keyserver);
- } /* keyserver_set_default */
+ }
- static const char *
+ /* Skip all kind of whitespace chars in @str. */
- skip_whitespace (const char * str)
+ static const char*
+ skip_whitespace (const char *str)
  {
-     while (str && *str)
+     while (str && *str) {
-     {
          if (*str == ' ' ||
              *str == '\t' ||
              *str == '\n' ||
-             *str == '\r')
+             *str == '\r') {
-         {
              str++;
              continue;
          }
-Line 465 
 skip_whitespace (const char * str)
+Line 536 
 skip_whitespace (const char * str)
  }
+ /* Save the keyserver config file in @conf. */
  int
- kserver_load_conf (const char * conf)
+ kserver_save_conf (const char *conf)
+ {
+     FILE *fp;
+     int pos;
+     fp = fopen (conf, "wb");
+     if (!fp) {
+         msg_box (NULL, _("Could not save keyserver.conf file"),
+                  _("Keyserver"), MB_ERR);
+         return -1;
+     }
+     fprintf (fp, "# do NOT manually modify this file, it will be "
+                  "generated automatically!!\r\n");
+     for (pos = 0; pos < MAX_KEYSERVERS; pos++) {
+         if (!server[pos].used)
+             continue;
+         fprintf (fp, "%s:%d\r\n", server[pos].name, server[pos].port);
+     }
+     fclose (fp);
+     return 0;
+ }
+ /* Load the keyserver config file @conf. */
+ int
+ kserver_load_conf (const char *conf)
  {
      struct stat statbuf;
      FILE *fp;
-     char buf[1024], * s, *p;
+     char buf[1024], *s, *p;
      char *user = NULL, *pass = NULL;
-     int pos;
      int no_config=0, chk_pos=0;
+     int pos;
      for (pos = 0; pos < MAX_KEYSERVERS; pos++) {
          server[pos].used = 0;
-Line 489 
 kserver_load_conf (const char * conf)
+Line 587 
 kserver_load_conf (const char * conf)
          }
          no_config=1;
      }
-     get_reg_proxy_prefs (&proxy.host, &proxy.port, &user, &pass);
+     get_reg_proxy_prefs (&proxy);
      if (user && pass)
-         kserver_update_proxyuser (user, pass);
+         update_proxy_user (user, pass);
      else if (user && !pass || !user && pass) {
-         msg_box( NULL, _("Invalid proxy configuration."
+         msg_box (NULL, _("Invalid proxy configuration."
                           "You need to set a user and a password"
-                          "to use proxy authentication!"), _("Proxy Error"), MB_ERR );
+                          "to use proxy authentication!"),
+                          _("Proxy Error"), MB_ERR);
      }
      /* check if the host has a http:// prefix and skip it */
-     if( proxy.host && !strncmp( proxy.host, "http://", 7 ) ) {
+     if (proxy.host && !strncmp (proxy.host, "http://", 7)) {
-         char *pr = m_strdup (proxy.host+7);
+         char *host = m_strdup (proxy.host+7);
-         if (!pr)
+         if (!host)
-             BUG (NULL);
+             BUG (0);
          free_if_alloc (proxy.host);
-         proxy.host = pr;
+         proxy.host = host;
      }
      free_if_alloc (user);
      free_if_alloc (pass);
      pos = 0;
-     while( fp && !feof( fp ) ) {
+     while (fp && !feof (fp)) {
          s = fgets (buf, sizeof (buf)-1, fp);
          if (!s)
              break;
-Line 526 
 kserver_load_conf (const char * conf)
+Line 625 
 kserver_load_conf (const char * conf)
                               _("Keyserver Error"), MB_ERR);
              continue;
          }
-         chk_pos=6;
+         chk_pos = 6;
          if (strstr (s, "finger"))
              chk_pos = 10;
          p = strchr (s+chk_pos, ':');
-Line 547 
 kserver_load_conf (const char * conf)
+Line 646 
 kserver_load_conf (const char * conf)
          }
          pos++;
          if (pos > MAX_KEYSERVERS) {
-             msg_box (NULL, _("The keyserver limit is exceeded"), _("Keyserver Warning"), MB_INFO);
+             msg_box (NULL, _("The keyserver limit is exceeded"),
+                      _("Keyserver Warning"), MB_INFO);
              break;
          }
      }
      if (fp)
          fclose (fp);
      if (!pos) {
-         /* only issue an error if the config file exist but it has no valid entries. */
+         /* only issue an error if the config file exist but
+            it has no valid entries. */
          keyserver_set_default (NULL, HKP_PORT);
          if (!no_config)
              return WPTERR_CONFIG_FILE;
      }
      if (!stat (conf, &statbuf))
          conf_timestamp = statbuf.st_mtime;
      return 0;
- } /* kserver_load_conf */
+ }
- const char *
- kserver_get_proxy (int * r_port)
- {
-     if (proxy.host) {
-         if (r_port)
-             *r_port = proxy.port;
-         return proxy.host;
-     }
-     return NULL;
- } /* kserver_get_proxy */
- const char *
- kserver_get_proxy_info (int id)
- {
-     switch (id) {
-     case PROXY_USER: return proxy.user;
-     case PROXY_PASS: return proxy.pass;
-     }
-     return NULL;
- } /* kserver_get_proxy_info */
- /* Connect to the keyserver @hostname. */
+ /* Connect to the keyserver @hostname (port @port).
+    Return value: 0 on success */
  int
- kserver_connect (const char *hostname, u16 port, int *conn_fd)
+ kserver_connect (const char *hostname, WORD port, int *conn_fd)
  {
      int rc, fd;
-     u32 iaddr;
+     DWORD iaddr;
      char host[128] = {0};
      struct hostent *hp;
      struct sockaddr_in sock;
-Line 625 
 kserver_connect (const char *hostname, u
+Line 704 
 kserver_connect (const char *hostname, u
          memcpy (&sock.sin_addr, hp->h_addr, hp->h_length);
      }
      else {
-         log_debug ("gethostbyname: failed.\r\n");
+         log_debug ("gethostbyname: failed ec=%d.\r\n", net_errno);
          return WPTERR_WINSOCK_RESOLVE;
      }
      fd = socket (AF_INET, SOCK_STREAM, 0);
-Line 633 
 kserver_connect (const char *hostname, u
+Line 712 
 kserver_connect (const char *hostname, u
          return WPTERR_WINSOCK_SOCKET;
      rc = connect (fd, (struct sockaddr *) &sock, sizeof (sock));
      if (rc == SOCKET_ERROR) {
-         log_debug ("connect: failed.\r\n");
+         log_debug ("connect: failed ec=%d.\r\n", net_errno);
          closesocket (fd);
          return WPTERR_WINSOCK_CONNECT;
      }
+     if (proxy.proto != PROXY_PROTO_HTTP) {
+         rc = socks_handshake (&proxy, fd, hostname, port);
+         if (rc) {
+             closesocket (fd);
+             return WPTERR_GENERAL; /* XXX: use better code. */
+         }
+     }
      if (conn_fd)
          *conn_fd = fd;
      WSASetLastError (0);
      return 0;
- } /* kserver_connect */
+ }
- /* Perform URL-encoding on the given pubkey blob. */
+ static bool
- static char*
+ URL_must_encoded (const char *url)
- kserver_urlencode (const char *pubkey, size_t octets, size_t *newlen)
  {
-     char *p, numbuf[5];
+     if (strchr (url, '.') || strchr (url, '@') || strchr (url, ' '))
-     size_t j = 0;
+         return true;
-     size_t i, size;
+     return false;
+ }
-     p = new char [2*octets];
-     if (!p)
-         BUG (0);
-     for (size=0, i=0; i < octets; i++) {
-         if (isalnum (pubkey[i]) || pubkey[i] == '-') {
+ /* Perform URL encoding of the given data. */
-             p[size] = pubkey[i];
+ static char*
-             size++;
+ URL_encode (const char *url, size_t ulen, size_t *ret_nlen)
-         }
+ {
-         else if (pubkey[i] == ' ') {
+     gpgme_data_t hd;
-             p[size] = '+';
+     char numbuf[5], *pp, *p;
-             size++;
+     size_t i, n;
-         }
+     gpgme_data_new (&hd);
+     for (i=0; i < ulen; i++) {
+         if (isalnum (url[i]) || url[i] == '-')
+             gpg_data_putc (hd, url[i]);
+         else if (url[i] == ' ')
+             gpg_data_putc (hd, '+');
          else {
-             sprintf(numbuf, "%%%02X", pubkey[i]);
+             sprintf (numbuf, "%%%02X", url[i]);
-             for (j = 0; j<strlen(numbuf); j++) {
+             gpgme_data_write (hd, numbuf, strlen (numbuf));
-                 p[size] = numbuf[j];
-                 size++;
-             }
          }
      }
-     p[size] = '\0';
+     gpg_data_putc (hd, '\0');
-     *newlen = size;
+     /* Copy memory to avoid that we need to use gpgme_free later. */
+     pp = gpgme_data_release_and_get_mem (hd, &n);
+     p = m_strdup (pp);
+     gpgme_free (pp);
+     if (ret_nlen)
+         *ret_nlen = n;
      return p;
  }
  /* Format a request for the given keyid (send). */
  static char*
- kserver_send_request (const char *hostname, u16 port, const char *pubkey, int octets)
+ kserver_send_request (const char *hostname, WORD port,
+                       const char *pubkey, int octets)
  {
-     char *request = NULL, *enc_pubkey = NULL;
+     char *request = NULL;
-     int reqlen;
+     char *enc_pubkey = NULL;
      size_t enc_octets;
+     int reqlen;
-     log_debug ("kserver_send_request: %s:%d\n", hostname, port);
+     log_debug ("kserver_send_request: %s:%d\r\n", hostname, port);
      if (!port)
          port = HKP_PORT;
-Line 696 
 kserver_send_request (const char *hostna
+Line 790 
 kserver_send_request (const char *hostna
      request = new char[reqlen];
      if (!request)
          BUG (0);
-     enc_pubkey = kserver_urlencode (pubkey, octets, &enc_octets);
+     enc_pubkey = URL_encode (pubkey, octets, &enc_octets);
      if (!enc_pubkey || !enc_octets) {
          free_if_alloc (request);
          return NULL;
      }
-     if (proxy.user) {
+     if (proxy.user && proxy.proto == PROXY_PROTO_HTTP) {
          _snprintf (request, reqlen-1,
                     "POST http://%s:%d/pks/add HTTP/1.0\r\n"
                     "Referer: \r\n"
-Line 728 
 kserver_send_request (const char *hostna
+Line 822 
 kserver_send_request (const char *hostna
                     "\r\n"
                     "keytext=%s"
                     "\n",
-                    skip_type_prefix (hostname), port, enc_octets+9, enc_pubkey);
+                    skip_type_prefix (hostname), port,
+                    enc_octets+9, enc_pubkey);
      }
      free_if_alloc (enc_pubkey);
-     log_debug ("%s\n", request);
+     log_debug ("%s\r\n", request);
      return request;
- } /* kserver_send_request */
+ }
- /* Interface receiving a public key. */
  int
- kserver_recvkey (const char *hostname, u16 port, const char *keyid, char *key, int maxkeylen)
+ kserver_recvkey_ext (const char *hostname, WORD port, const char *keyid,
- {
+                      char **r_key, int *r_keylen)
-     int rc, n;
+ {
-     int conn_fd;
      char *request = NULL;
+     int conn_fd;
+     int rc, n;
      if (!port)
          port = HKP_PORT;
      hkp_err = 0; /* reset */
-Line 756 
 kserver_recvkey (const char *hostname, u
+Line 851 
 kserver_recvkey (const char *hostname, u
      if (!request)
          BUG (0);
-     if (proxy.host && proxy.user) {
+     if (proxy.host && proxy.user && proxy.proto == PROXY_PROTO_HTTP) {
          _snprintf (request, 300,
              "GET http://%s:%d/pks/lookup?op=get&search=%s HTTP/1.0\r\n"
              "Proxy-Authorization: Basic %s\r\n\r\n",
              skip_type_prefix (hostname), port, keyid, proxy.base64_user);
      }
-     else if (proxy.host) {
+     else if (proxy.host && proxy.proto == PROXY_PROTO_HTTP) {
          _snprintf (request, 300,
              "GET http://%s:%d/pks/lookup?op=get&search=%s HTTP/1.0\r\n\r\n",
              skip_type_prefix (hostname), port, keyid);
-Line 780 
 kserver_recvkey (const char *hostname, u
+Line 875 
 kserver_recvkey (const char *hostname, u
          goto leave;
      }
-     rc = sock_read( conn_fd, key, maxkeylen, &n );
+     rc = sock_read_ext (conn_fd, r_key, &n);
-     if( rc == SOCKET_ERROR ) {
+     if (rc == SOCKET_ERROR) {
          rc = WPTERR_WINSOCK_RECVKEY;
          goto leave;
      }
-     log_debug("%s\r\n", key);
+     if (r_keylen)
-     rc = check_hkp_response (key, 1);
+         *r_keylen = n;
+     log_debug("%s\r\n", *r_key);
+     rc = check_hkp_response (*r_key, 1);
      if (rc)
          goto leave;
-Line 797 
 leave:
+Line 894 
 leave:
      closesocket (conn_fd);
      free_if_alloc (request);
      return rc;
- } /* kserver_recvkey */
+ }
+ /* Interface for receiving a public key. */
+ int
+ kserver_recvkey (const char *hostname, WORD port, const char *keyid,
+                  char *key, int maxkeylen)
+ {
+     char *tmpkey;
+     int rc, nread=0;
+     /* XXX: just a wrapper around the new method, replace it
+             soon as possible. */
+     rc = kserver_recvkey_ext (hostname, port, keyid, &tmpkey, &nread);
+     if (rc)
+         return rc;
+     if (nread > maxkeylen) {
+         free_if_alloc (tmpkey);
+         return WPTERR_GENERAL;
+     }
+     strcpy (key, tmpkey);
+     free_if_alloc (tmpkey);
+     return 0;
+ }
  /* Interface to send a public key. */
  int
- kserver_sendkey (const char *hostname, u16 port, const char *pubkey, int len )
+ kserver_sendkey (const char *hostname, WORD port, const char *pubkey, int len )
  {
-     int n, rc;
-     int conn_fd;
      char *request = NULL;
      char log[2048];
+     int conn_fd, n;
+     int rc;
      hkp_err = 0; /* reset */
      rc = kserver_connect (hostname, port, &conn_fd);
-Line 820 
 kserver_sendkey (const char *hostname, u
+Line 940 
 kserver_sendkey (const char *hostname, u
          goto leave;
      }
-     rc = sock_write( conn_fd, request, lstrlen(request) );
+     rc = sock_write (conn_fd, request, strlen (request));
-     if( rc == SOCKET_ERROR ) {
+     if (rc == SOCKET_ERROR) {
          rc = WPTERR_WINSOCK_SENDKEY;
          goto leave;
      }
-     rc = sock_read( conn_fd, log, sizeof (log)-1, &n );
+     rc = sock_read (conn_fd, log, sizeof (log)-1, &n);
-     if( rc == SOCKET_ERROR ) {
+     if (rc == SOCKET_ERROR) {
          rc = WPTERR_WINSOCK_SENDKEY;
          goto leave;
      }
      log_debug ("kserver_sendkey:\r\n%s\r\n", log);
      rc = check_hkp_response (log, 0);
-     if( rc )
+     if (rc)
          goto leave;
      WSASetLastError (0);
-Line 844 
 leave:
+Line 963 
 leave:
      closesocket (conn_fd);
      free_if_alloc (request);
      return rc;
- } /* kserver_sendkey */
+ }
  int
- kserver_search_init (const char * hostname, u16 port, const char * keyid, int * conn_fd)
+ kserver_search_init (const char *hostname, WORD port,
+                      const char *keyid, int *conn_fd)
  {
+     char *request = NULL;
+     char *enc_keyid = NULL;
+     int n = 0;
      int rc, sock_fd;
-     int n=0;
-     char * request = NULL;
      rc = kserver_connect (hostname, port, &sock_fd);
      if (rc) {
          *conn_fd = 0;
          goto leave;
      }
+     enc_keyid = URL_encode (keyid, strlen (keyid), NULL);
      n=300;
      request = new char[n+1];
      if (!request)
          BUG (0);
-     if (proxy.host && proxy.user) {
+     if (proxy.host && proxy.user && proxy.proto == PROXY_PROTO_HTTP) {
          _snprintf (request, n,
              "GET http://%s:%d/pks/lookup?op=index&search=%s HTTP/1.0\r\n"
              "Proxy-Authorization: Basic %s\r\n\r\n",
-             skip_type_prefix (hostname), port, keyid, proxy.base64_user);
+             skip_type_prefix (hostname), port, enc_keyid, proxy.base64_user);
      }
-     else if (proxy.host) {
+     else if (proxy.host && proxy.proto == PROXY_PROTO_HTTP) {
          _snprintf (request, n,
              "GET http://%s:%d/pks/lookup?op=index&search=%s HTTP/1.0\r\n\r\n",
-             skip_type_prefix (hostname), port, keyid);
+             skip_type_prefix (hostname), port, enc_keyid);
      }
      else {
          _snprintf (request, n,
-                    "GET /pks/lookup?op=index&search=%s HTTP/1.0\r\n\r\n", keyid);
+                    "GET /pks/lookup?op=index&search=%s HTTP/1.0\r\n\r\n",
+                    enc_keyid);
      }
      log_debug ("kserver_search_init:\r\n%s\r\n", request);
-Line 892 
 kserver_search_init (const char * hostna
+Line 1015 
 kserver_search_init (const char * hostna
  leave:
      free_if_alloc (request);
+     free_if_alloc (enc_keyid);
      return rc;
- } /* kserver_search_init */
+ }
+ /* Check keyserver response. */
  int
  kserver_search_chkresp (int fd)
  {
-Line 912 
 kserver_search_chkresp (int fd)
+Line 1037 
 kserver_search_chkresp (int fd)
      if (strncmp (buf+(8+1), "200", 3))
          return WPTERR_KEYSERVER_NOTFOUND;
      return 0;
- } /* kserver_search_chkresp */
+ }
+ /* Convert an iso date @iso_date (YYYY-MM-DD) into the locale
+    representation and store it into @loc_date.
+    Return value: 0 on success. */
+ static int
+ parse_iso_date (const char *iso_date, char *loc_date, size_t loclen)
+ {
+     SYSTEMTIME st;
+     char buf[16] = {0}, *p;
+     int pos=0;
+     strncpy (buf, iso_date, sizeof (buf)-1);
+     p = strtok (buf, "-");
+     while (p != NULL) {
+         switch (pos) {
+         case 0: st.wYear  = (WORD)atoi (p); pos++; break;
+         case 1: st.wMonth = (WORD)atoi (p); pos++; break;
+         case 2: st.wDay   = (WORD)atoi (p); pos++; break;
+         default: break;
+         }
+         p = strtok (NULL, "-");
+     }
+     if (pos != 3)
+         return -1;
+     if (!GetDateFormat (LOCALE_USER_DEFAULT, DATE_SHORTDATE, &st,
+                         NULL, loc_date, loclen))
+         return -1;
+     return 0;
+ }
  int
- kserver_search (int fd, keyserver_key * key)
+ kserver_search (int fd, keyserver_key *key)
  {
      char buf[1024], *p;
      int uidlen, nbytes, pos = 0;
-     log_debug ("keyserver_search:\n");
+     log_debug ("keyserver_search:\r\n");
      if (sock_getline (fd, buf, sizeof (buf) - 1, &nbytes))
          return WPTERR_GENERAL;
-     log_debug ("%s\n", buf);
+     log_debug ("%s\r\n", buf);
      if (!strncmp (buf, "pub", 3)) {
          int revoked = strstr (buf, "KEY REVOKED") != NULL? 1 : 0;
-Line 943 
 kserver_search (int fd, keyserver_key *
+Line 1099 
 kserver_search (int fd, keyserver_key *
          pos = p - buf + 5;
          memcpy (key->date, buf + pos, 10);
          key->date[10] = '\0';
+         parse_iso_date (key->date, key->date, sizeof (key->date)-1);
          if (revoked) {
              strcpy (key->uid, "KEY REVOKED: not checked");
              return 0;
-Line 953 
 kserver_search (int fd, keyserver_key *
+Line 1110 
 kserver_search (int fd, keyserver_key *
              p++;
          p++;
          uidlen = strlen (p) - 10;
+         if (!strstr (p, "&lt;") && !strstr (p, "&gt;")) {
+             pos=0;
+             while (p && *p && pos < sizeof (key->uid)-1) {
+                 if (*p == '<')
+                     break;
+                 key->uid[pos++] = *p++;
+             }
+             key->uid[pos] ='\0';
+             return 0;
+         }
+         if (uidlen > sizeof (key->uid)-1)
+             uidlen = sizeof (key->uid)-1;
          memcpy (key->uid, p, uidlen);
          key->uid[uidlen] = '\0';
          strcat (key->uid, ">");
          p = strchr (key->uid, '&');
          if (p) {
              key->uid[(p-key->uid)] = '<';
-             memmove (key->uid+(p-key->uid)+1, key->uid+(p-key->uid)+4, strlen (key->uid)-3);
+             memmove (key->uid+(p-key->uid)+1, key->uid+(p-key->uid)+4,
+                      strlen (key->uid)-3);
          }
          return 0;
      }
-Line 968 
 fail:
+Line 1139 
 fail:
      key->bits = 0;
      memset (key, 0, sizeof *key);
      return 0;
- } /* kserver_search */
+ }
- static int
- add_node( keyserver_cfgfile *cfg, const char *entry )
- {
-     keyserver_node *node;
-     char *p = NULL;
-     p = strchr( entry, '=' );
-     if( p == NULL )
-         return WPTERR_GENERAL;
-     node = new keyserver_node;
-     if( !node )
-         BUG( NULL );
-     memset( node, 0, sizeof *node );
-     node->used = 1;
-     node->host.used = 1;
-     node->host.proto = proto_from_URL( entry );
-     memcpy( node->host.name, entry+7, p-entry-7 );
-     node->next = cfg->list;
-     cfg->list = node;
-     return 0;
- } /* add_node */
+ /* Release mbmers in the proxy context @ctx. */
  void
- kserver_change_proxy( keyserver_proxy_ctx *ctx )
+ kserver_proxy_release (keyserver_proxy_t ctx)
- {
-     proxy.port = ctx->port;
-     free_if_alloc (proxy.host);
-     proxy.host = ctx->host? m_strdup( ctx->host ) : NULL;
-     free_if_alloc( proxy.pass );
-     proxy.pass = ctx->pass? m_strdup( ctx->pass ) : NULL;
-     free_if_alloc( proxy.user );
-     proxy.user = ctx->user? m_strdup( ctx->user ) : NULL;
-     set_reg_proxy_prefs( proxy.host, proxy.port, proxy.user, proxy.pass );
- } /* kserver_change_proxy */
- int
- kserver_read_config( const char *fname, keyserver_cfgfile **ret_cfg )
  {
-     FILE *fp;
+     free_if_alloc (ctx->host);
-     keyserver_cfgfile *cfg;
+     free_if_alloc (ctx->pass);
-     char buf[256];
+     free_if_alloc (ctx->user);
-     int rc = 0;
+ }
-     *ret_cfg = NULL;
-     fp = fopen( fname, "rb" );
-     if( fp == NULL )
-         return WPTERR_FILE_OPEN;
-     cfg = new keyserver_cfgfile;
-     if ( !cfg )
-         BUG( NULL );
-     memset( cfg, 0, sizeof *cfg );
-     while ( !feof( fp ) ) {
-         if ( fgets( buf, sizeof(buf)-1, fp ) == NULL )
-             break;
-         if ( *buf == '\r' || *buf == '\n' || *buf == '#' )
-             continue;
-         buf[strlen(buf) -2] = '\0';
-         if ( !strncmp( buf, "use_proxy=", 10 ) ) {
-             char *p = strchr(buf, ':');
-             if (!p)
-                 continue;
-             cfg->proxy.port = atol( buf+(p-buf+1) );
-             buf[p-buf] = '\0';
-             cfg->proxy.host = m_strdup( buf+10 );
-         }
-         else if ( !strncmp( buf, "proxy_user=", 11 ) )
-             cfg->proxy.user = m_strdup( buf+11 );
-         else if ( !strncmp( buf, "proxy_pass=", 11 ) )
-             cfg->proxy.pass = m_strdup( buf+11 );
-         if ( !strncmp( buf, "http://", 7 )
-             || !strncmp( buf, "hkp://", 6 )
-             || !strncmp( buf, "ldap://", 7 ) ) {
-             add_node( cfg, buf );
-             cfg->nlist++;
-         }
-     }
-     fclose( fp );
-     *ret_cfg = cfg;
-     return rc;
- } /* kserver_read_config */
- int
+ /* Spawn a process given by @cmdl. */
- kserver_write_config( const char * fname, keyserver_cfgfile * cfg )
+ static int
+ spawn_application (char *cmdl)
  {
+     STARTUPINFO si;
-     return 0;
+     PROCESS_INFORMATION pi;
- }
+     int rc = 0;
- void
+     memset (&si, 0, sizeof (si));
- kserver_cfgfile_release( keyserver_cfgfile *cfg )
+     si.cb = sizeof (si);
- {
+     si.dwFlags = STARTF_USESHOWWINDOW;
-     keyserver_node *k, *k2;
+     si.wShowWindow = SW_HIDE;
+     memset (&pi, 0, sizeof (pi));
-     proxy_release( &cfg->proxy );
+     if (!CreateProcess (NULL, cmdl, NULL, NULL, FALSE, 0,
-     for( k = cfg->list; cfg->nlist--; k = k2 ) {
+                         NULL, NULL, &si, &pi)) {
-         k2 = k->next;
+         log_box ("Keyserver Plugin", MB_ERR, "Could not spawn helper process");
-         free_if_alloc( k );
+         rc = -1;
      }
-     free_if_alloc( cfg );
- } /* kserver_cfgfile_release */
- void
+     CloseHandle (pi.hThread);
- proxy_release( keyserver_proxy_ctx *ctx )
+     WaitForSingleObject (pi.hProcess, INFINITE);
- {
+     CloseHandle (pi.hProcess);
-     free_if_alloc( ctx->host );
+     return rc;
-     free_if_alloc( ctx->pass );
+ }
-     free_if_alloc( ctx->user );
- } /* proxy_release */
- int
+ /* Receive an key via LDAP from host @host with the keyid @keyid.
- ldap_recvkey (const char * host, const char * keyid, char * key, int maxkeylen)
+    @key contains the key on success. */
- {
+ int
+ ldap_recvkey (const char *host, const char *keyid, char *key, int maxkeylen)
+ {
+     FILE *fp;
      const char *s;
-     char *ksprg = NULL, *p = NULL;
+     char *ksprg = NULL, *p = NULL, *sep;
-     char temp[512], outf[512];
+     char inf[256], outf[256], buf[512];
-     FILE * inp;
+     DWORD n;
-     int rc, start_key = 0;
+     int start_key = 0, failed = 0;
-     STARTUPINFO si;
+     int rc = 0;
-     PROCESS_INFORMATION pi;
-     p = get_gnupg_path ();
+     p = get_gnupg_prog ();
-     ksprg = new char[strlen (p) + 1 + 128];
+     n = strlen (p) + 1 + 128;
+     ksprg = new char[n+1];
      if (!ksprg)
          BUG (0);
-     strcpy (ksprg, p);
+     sep = strrchr (p, '\\');
-     strcat (ksprg, "\\");
+     if (sep != NULL)
-     strcat (ksprg, "gpgkeys_ldap.exe");
+         p[(sep-p)] = 0;
+     _snprintf (ksprg, n, "%s\\gpgkeys_ldap.exe", p);
      free_if_alloc (p);
      if (file_exist_check (ksprg)) {
-         log_box ( "LDAP Keyserver Plugin", MB_ERR, "Could not find LDAP keyserver module!");
+         log_box ("LDAP Keyserver Plugin", MB_ERR,
-         rc = -1;
+                  "%s: could not find LDAP keyserver module!", ksprg);
+         rc = -1;
          goto leave;
      }
-     GetTempPath (sizeof (temp)-1, temp);
+     get_temp_name (outf, sizeof (outf)-1, keyid);
-     strcpy (outf, temp);
+     get_temp_name (inf, sizeof (inf)-1, NULL);
-     strcat (outf, keyid);
+     fp = fopen (inf, "w+b");
-     strcat (outf, ".out");
+     if (!fp) {
-     strcat (temp, keyid);
+         log_box ("LDAP Keyserver Plugin", MB_ERR, "%s: %s", inf,
-     inp = fopen (temp, "w+b");
-     if( !inp ) {
-         log_box ("LDAP Keyserver Plugin", MB_ERR, "%s: %s", temp,
                   winpt_strerror (WPTERR_FILE_OPEN));
          rc = -1;
          goto leave;
      }
-     fprintf (inp,
+     fprintf (fp,
-         "VERSION 0\n"
+         "VERSION 1\n"
+         "PROGRAM 1.4.3-cvs\n"
+         "SCHEME ldap\n"
          "HOST %s\n"
-         "OPTION verbose\n"
          "COMMAND GET\n"
          "\n"
-         "%s\n", host? skip_type_prefix (host): "64.94.85.200", keyid);
+         "%s\n",
-     fclose (inp);
+         host? skip_type_prefix (host): "64.94.85.200", keyid);
+     fclose (fp);
-     memset (&si, 0, sizeof (si));
+     p = new char[strlen (ksprg) + strlen (inf) + strlen (outf) + 32];
-     si.cb = sizeof (si);
+     if (!p)
-     si.dwFlags = STARTF_USESHOWWINDOW;
+         BUG (NULL);
-     si.wShowWindow = SW_HIDE;
+     sprintf (p, "%s -o %s %s", ksprg, outf, inf);
-     memset (&pi, 0, sizeof (pi));
+     if (spawn_application (p)) {
-     p = new char[strlen (ksprg) + strlen (temp) + strlen (outf) + 32];
-     sprintf (p, "%s -o %s %s", ksprg, outf, temp);
-     rc = CreateProcess (NULL, p, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi);
-     if (!rc) {
-         log_box ("LDAP Keyserver Plugin", MB_ERR, "Could not spawn process");
          rc = -1;
          goto leave;
      }
-     CloseHandle (pi.hThread);
-     WaitForSingleObject (pi.hProcess, INFINITE);
-     CloseHandle (pi.hProcess);
-     inp = fopen (outf, "rb");
+     fp = fopen (outf, "rb");
-     if (!inp) {
+     if (!fp) {
          log_box ("LDAP Keyserver Plugin", MB_ERR, "%s: %s", outf,
                   winpt_strerror (WPTERR_FILE_OPEN));
          rc = -1;
          goto leave;
      }
      memset (key, 0, maxkeylen);
-     while( !feof( inp ) ) {
+     while (!feof (fp)) {
-         s = fgets( temp, sizeof (temp)-1, inp );
+         s = fgets (buf, sizeof (buf)-1, fp);
-         if( !s )
+         if (!s)
              break;
-         if( !start_key && strstr( s, "KEY" ) && strstr( s, "BEGIN" ) ) {
+         if (strstr (s, "KEY") && strstr (s, "FAILED")) {
+             failed = 1;
+             break;
+         }
+         if (!start_key && strstr (s, "KEY") && strstr (s, "BEGIN")) {
              start_key = 1;
              continue;
          }
-         if( !start_key )
+         if (!start_key)
              continue;
-         strcat( key, temp );
+         strcat (key, buf);
-         maxkeylen -= strlen( temp );
+         maxkeylen -= strlen (buf);
-         if( maxkeylen < 0 || (strstr( s, "KEY" ) && strstr( s, "END" )) )
+         if (maxkeylen < 0 || (strstr (s, "KEY") && strstr (s, "END")))
              break;
      }
-     fclose( inp );
+     fclose (fp);
  leave:
-     if( !strlen( key ) )
+     if (failed || !strlen (key))
          rc = WPTERR_WINSOCK_RECVKEY;
-     free_if_alloc( p );
+     DeleteFile (inf);
-     free_if_alloc( ksprg );
+     DeleteFile (outf);
+     free_if_alloc (p);
+     free_if_alloc (ksprg);
      return rc;
- } /* ldap_recvkey */
- static int
- finger_readline (int fd, char * buf, int nbytes)
- {
-     char c = 0;
-     int n, pos = 0;
-     while (nbytes > 0) {
-         n = recv (fd, &c, 1, 0);
-         if (n <= 0)
-             break;
-         if (c == '\n')
-             break;
-         buf[pos++] = c;
-         nbytes--;
-     }
-     if (nbytes > 0)
-         buf[pos++] = '\0';
-     if (n <= 0)
-         pos = n;
-     return pos;
  }
+ /* Receive an key via FINGER from host @host with the user @user.
+    On success @key contains the key. */
  int
- finger_recvkey (const char * host, const char * user, char * key, int maxkeylen)
+ finger_recvkey (const char *host, const char *user, char *key, int maxkeylen)
  {
-     struct hostent * hp;
-     struct sockaddr_in saddr;
      char buf[128];
      int fd, nread;
      int start_key = 0;
      int rc=0;
-     fd = socket (PF_INET, SOCK_STREAM, 0);
+     rc = kserver_connect (host, FINGER_PORT, &fd);
-     if (fd == -1)
+     if (rc)
-         return WPTERR_WINSOCK_SOCKET;
+         return rc;
-     hp = gethostbyname (skip_type_prefix (host));
-     if (!hp) {
-         closesocket (fd);
-         return WPTERR_WINSOCK_RESOLVE;
-     }
-     memset (&saddr, 0, sizeof (saddr));
+     sock_write (fd, user, strlen (user));
-     saddr.sin_family = AF_INET;
+     sock_write (fd, "\r\n", 2);
-     saddr.sin_port = htons (FINGER_PORT);
-     saddr.sin_addr = *(struct in_addr *)hp->h_addr;
-     if (connect (fd, (struct sockaddr *)&saddr, sizeof (saddr))) {
-         closesocket (fd);
-         return WPTERR_WINSOCK_CONNECT;
-     }
-     send (fd, user, strlen (user), 0);
-     send (fd, "\r\n", 2, 0);
      memset (key, 0, maxkeylen);
      while (maxkeylen > 0) {
-         nread = finger_readline (fd, buf, sizeof (buf)-1);
+         if (sock_getline (fd, buf, sizeof (buf), &nread))
-         if (nread <= 0)
+             break;
-             break;
          strcat (buf, "\n");
          if (strstr (buf, "BEGIN PGP PUBLIC KEY BLOCK")) {
              strcat (key, buf);
-Line 1271 
 finger_recvkey (const char * host, const
+Line 1323 
 finger_recvkey (const char * host, const
  }
+ /* Check if the given name @name is a valid hostname. */
  int
  check_IP_or_hostname (const char *name)
  {

 Legend:



Removed from v.73
 


changed lines


 
Added in v.180
 Legend:



Removed from v.73
 


changed lines


 
Added in v.180
-Removed from v.73
+Added in v.180

[email protected]	ViewVC Help
Powered by ViewVC 1.1.26